Hzfengsy commented on code in PR #11589:
URL: https://github.com/apache/tvm/pull/11589#discussion_r890772118
##########
src/arith/domain_touched.cc:
##########
@@ -34,18 +35,48 @@ namespace arith {
using namespace tir;
+struct LoadAccess {
Review Comment:
Can we use `using LoadAccess = std::vector<std::vector<IntSet>> set;`?
##########
src/te/operation/create_primfunc.cc:
##########
@@ -395,62 +395,75 @@ Stmt GenerateStmtFromExternOp(const te::ExternOp&
extern_op, CreateFuncInfo* inf
/*annotations=*/extern_op->attrs));
}
-PrimFunc CreatePrimFunc(const Array<te::Tensor>& arg_list) {
- // Step 1. Create tensor read graph.
+Array<te::Operation> CollectOrderedOps(const Array<te::Tensor>& arg_list) {
Array<te::Operation> arg_ops;
for (const te::Tensor& arg : arg_list) {
arg_ops.push_back(arg->op);
}
te::ReadGraph g = te::CreateReadGraph(arg_ops);
Array<te::Operation> order = te::PostDFSOrder(arg_ops, g);
- // Step 2. Checking all Operations are supported.
for (const te::Operation& op : order) {
if (!(op->IsInstance<te::PlaceholderOpNode>() ||
op->IsInstance<te::ComputeOpNode>() ||
op->IsInstance<te::ExternOpNode>()))
LOG(FATAL) << "TypeError: Unsupported Operation: " << op->GetTypeKey()
<< ". "
<< "Only te.placeholder and te.compute are allowed for now.";
}
+ return order;
+}
- // Infomations used in CreatePrimFunc and its sub-functions.
- CreateFuncInfo info(arg_list);
- // Root body stmts.
- Array<Stmt> root_stmts;
- // Analyzer
- arith::Analyzer analyzer;
+void InitializeBufferBinds(const Array<te::Operation>& ordered_ops,
CreateFuncInfo* info) {
+ // Process any TE operations which contain user defined buffers
+ for (const auto& op : ordered_ops) {
+ // Initialize the tensor2buffer binds map with buffers defined by the
te.extern
+ if (const auto extern_op = op.as<te::ExternOpNode>()) {
Review Comment:
```suggestion
if (const auto* extern_op = op.as<te::ExternOpNode>()) {
```
##########
tests/python/unittest/test_meta_schedule_relay_tir_compute.py:
##########
@@ -0,0 +1,191 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import numpy as np
+import tvm
+import tvm.testing
+import tvm.topi.testing
+
+from tvm.script import tir as T
+from tvm import tir, te, relay, topi, autotvm
+from tvm.relay.testing.temp_op_attr import TempOpAttr
+from tvm.meta_schedule import ApplyHistoryBest
+from tvm.meta_schedule.testing import apply_fixed_schedules
+
+
+def compute_tir_conv2d_nchw_oihw(data_shape, weight_shape, dtype):
+ assert dtype == "float32"
+ OC, IC, FH, FW = weight_shape
+
+ padding = (0, 0, 0, 0)
+ strides = (1, 1)
+ dilation = (1, 1)
+ output_shape = (
+ data_shape[0],
+ weight_shape[0],
+ (data_shape[2] - ((weight_shape[2] - 1) * dilation[0] + 1) +
padding[0] + padding[1])
+ // strides[0]
+ + 1,
+ (data_shape[3] - ((weight_shape[3] - 1) * dilation[1] + 1) +
padding[2] + padding[3])
+ // strides[1]
+ + 1,
+ )
+ N, K, BH, BW = output_shape
+
+ @T.prim_func
+ def conv2d(
+ a: T.handle,
+ filt: T.handle,
+ b: T.handle,
+ ) -> None:
+ T.func_attr({"global_symbol": "main", "tir.noalias": True})
+ A = T.match_buffer(a, data_shape, dtype=dtype)
+ Filter = T.match_buffer(filt, weight_shape, dtype=dtype)
+ B = T.match_buffer(b, output_shape, dtype=dtype)
Review Comment:
It looks wired after `black` formatting. You can add `# fmt: off` and `#
fmt: on` to turn off formatting for a part of python codes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
