AndrewZhaoLuo commented on code in PR #11574: URL: https://github.com/apache/tvm/pull/11574#discussion_r891479849
########## src/tir/transforms/common_subexpr_elim.cc: ########## @@ -120,6 +120,39 @@ bool CommonSubexpressionEliminator::CanContainEligibleComputations(const PrimExp return true; } +/*! + * \brief Implements an order on pairs (expression,frequency). First attempts to compare them + using the size of the expression. If the is the same, decides something else still Review Comment: Can you improve the grammar of the last sentence `If the is the same...` ########## src/tir/transforms/common_subexpr_elim.cc: ########## @@ -120,6 +120,39 @@ bool CommonSubexpressionEliminator::CanContainEligibleComputations(const PrimExp return true; } +/*! + * \brief Implements an order on pairs (expression,frequency). First attempts to compare them + using the size of the expression. If the is the same, decides something else still Review Comment: nit: Can you improve the grammar of the last sentence `If the is the same...` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
