billishyahao commented on PR #11513: URL: https://github.com/apache/tvm/pull/11513#issuecomment-1151878485
> > > @billishyahao I remember that you introduced a mechanism to query optimal layout and alter op layout before the graph is consumed by DNNL, just like we do for `Conv`. Did you cancel that and do the layout transform in dnnl json runtime? If so, I agree with @apeskov and wondering why no layout transform of the weights. > > > > > > Yes, I do revert the change about altering op layout after I saw the PR #11345 from @apeskov . > > I think we need them both. Query and alter layout can do the reordering of the weights in build time to ensure optimal performance in run time. Sure. @yangulei Let me add this code mentioned in the following change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
