gigiblender commented on PR #12066: URL: https://github.com/apache/tvm/pull/12066#issuecomment-1181965331
> This is of course follows the design rationale of keeping things immutable, in this world, likely likely F0 and F1 will have similar effects and recreation when needed(in few times that it is necessary) may not be a bad idea. Thank you @tqchen for the review. I also prefer F0, where we always create for immediate use a fresh `NameSupply` or `GlobalVarSupply` from the IRModule. One possible issue I can see with both F0 and F1 is that usually the module name is used as a prefix to the GlobalVars that belong to the same module. Currently, the module name is not a member of `IRModule` and is only sometimes passed along (for example in `te_compiler.cc` `LowerTE`). One solution I was thinking about is to add the module name as an attribute to the `IRModule`. If no such attribute is present, then we can fallback to a default (as is the case currently in `te_compiler.cc` when a module name is not provided by the user). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
