kparzysz-quic commented on code in PR #12119:
URL: https://github.com/apache/tvm/pull/12119#discussion_r923507916
##########
src/target/target.cc:
##########
@@ -52,7 +52,7 @@ class TargetInternal {
static ObjectPtr<Object> FromString(const String&
tag_or_config_or_target_str);
static ObjectPtr<Object> FromConfigString(const String& config_str);
static ObjectPtr<Object> FromRawString(const String& target_str);
- static ObjectPtr<Object> FromConfig(std::unordered_map<String, ObjectRef>
config);
+ static ObjectPtr<Object> FromConfig(Map<String, ObjectRef> config);
Review Comment:
Given that this takes `Map<>` explicitly instead of `TargetJSON`, are there
any conditions that a config map must meet before it can be considered a target
JSON?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
