quic-sanirudh commented on code in PR #12082:
URL: https://github.com/apache/tvm/pull/12082#discussion_r923628416
##########
tests/python/contrib/test_hexagon/test_2d_physical_buffers.py:
##########
@@ -84,6 +83,12 @@ def target_host(target):
return tvm.target.Target(target, host=host)
+# Disabling redefined-outer-name for the whole file as there isn't any easy
+# solution yet to refactor tvm.testing.fixture fixtures that avoid redefining
+# outer variable names
+# pylint: disable=redefined-outer-name
Review Comment:
I'm not sure which 2 fixtures you mention here. Could you explain a little
more. There were lots of `tvm.testing.fixture` functions defined and they all
seemed to be interlinked, and I did not want to remove the
`tvm.testing.fixture` calls for all of them, so I just disabled the linter.
##########
tests/python/contrib/test_hexagon/test_benchmark_elemwise_add.py:
##########
@@ -151,6 +151,7 @@ def main(a: T.handle, b: T.handle, c: T.handle):
for j in range(dim1_size):
C[i, j] = A[i, j] + B[i, j]
+ # pylint: enable=no-self-argument,invalid-name,missing-function-docstring
Review Comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
