[GitHub] [tvm] shingjan commented on a diff in pull request #12141: [Meta Schedule][XGBoost] Update the custom callback function of xgboost in meta schedule

[GitBox]

shingjan commented on code in PR #12141:
URL: https://github.com/apache/tvm/pull/12141#discussion_r930721648


##########
python/tvm/meta_schedule/cost_model/xgb_model.py:
##########
@@ -35,7 +35,15 @@
 from ..utils import cpu_count, derived_object, shash2hex
 from .metric import max_curve
 
+
 if TYPE_CHECKING:
+    try:

Review Comment:
   if we put the import here builds in CI could fail. I think this is due to 
fact that we need this import instead of using `xgb` only as a type hint. 
@zxybazh Should we put it out of the `TYPE_CHECKING` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org