ganler commented on PR #12197: URL: https://github.com/apache/tvm/pull/12197#issuecomment-1197293248
@tkonolige Thanks for the suggestions. To put some background: The reason why I use these magic RGB values is to match exact themes in jupyter notebook (or vscode) so they will look _**compatible**._ In jupyter notebook, the colors will be displayed as what the RGB values exactly are since it uses HTML to render things. While for terminals, I guess it will map things to a nearest 3/4/8-bit colors. That said I fully agree that we want the theme look **_compatible_** for both notebook users and terminal users. My proposal is to: 1) first set them as different theme styles (including the theme you suggested that we have 3 tvm-builtin themes where 2 for jupyter notebook environemnts and 1 for terminal env); 2) we set the default style to a magic string, say "auto", and then we detect if the user is doing experiements in a notebook (if notebook -> "light"; if terminal -> ansi colors). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
