junrushao1994 commented on code in PR #12101:
URL: https://github.com/apache/tvm/pull/12101#discussion_r931524593
##########
include/tvm/node/structural_equal.h:
##########
@@ -99,7 +125,10 @@ class StructuralEqual : public BaseValueEqual {
* equality checking. Instead, it can store the necessary equality conditions
* and check later via an internally managed stack.
*/
-class SEqualReducer : public BaseValueEqual {
+class SEqualReducer {
Review Comment:
Given this PR removes the dependency from `SEqualReducer` to
`BaseValueEqual`, now the equality checking super class is used only by the
class `StructuralEqual`, so it might make more sense to completely absorb
`BaseValueEqual` into `StructuralEqual`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
