gigiblender commented on code in PR #12178: URL: https://github.com/apache/tvm/pull/12178#discussion_r933383395
########## tests/scripts/task_cpp_unittest.sh: ########## @@ -45,20 +45,23 @@ python3 tests/scripts/task_build.py \ --cmake-target cpptest \ --build-dir "${BUILD_DIR}" -# crttest requires USE_MICRO to be enabled, which is currently the case -# with all CI configs -pushd "${BUILD_DIR}" -ninja crttest -popd +# crttest requires USE_MICRO to be enabled. +if grep -Fq "set(USE_MICRO ON)" ${BUILD_DIR}/config.cmake; then Review Comment: Update: It seems that there are `crt` tests that get included in the cpp test suite when `USE_MICRO` is enabled. Instead of separating those, I am following @areusch advice and writing to a file all the options used to build TVM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org