jwfromm commented on code in PR #12284:
URL: https://github.com/apache/tvm/pull/12284#discussion_r939213908
##########
tests/python/topi/python/test_topi_prng.py:
##########
@@ -157,8 +185,27 @@ def test_uniform(target, dev):
assert np.max(rands) <= 10.0
+@tvm.testing.parametrize_targets
+def test_multinomial(target, dev):
+ def _verify_multinomial(size, num_samples):
Review Comment:
Thanks for this tip. I added a chisquare test which confirms that the
behavior of this function is expected.
##########
tests/python/topi/python/test_topi_prng.py:
##########
@@ -157,8 +185,27 @@ def test_uniform(target, dev):
assert np.max(rands) <= 10.0
+@tvm.testing.parametrize_targets
+def test_multinomial(target, dev):
+ def _verify_multinomial(size, num_samples):
Review Comment:
Thanks for this tip. I added a chisquared test which confirms that the
behavior of this function is expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
