zxybazh commented on code in PR #12463: URL: https://github.com/apache/tvm/pull/12463#discussion_r947337243
########## tests/python/unittest/test_tir_schedule_trace.py: ########## @@ -275,5 +284,39 @@ def test_apply_json_to_schedule_1(): tvm.ir.assert_structural_equal(elementwise_inlined, sch.mod["main"]) +def _test_apply_annotation_trace_from_json(annotation: str): + """Test applying an annotation works without crashing. + + Designed to handle some previously failing edge cases like the + empty string. + """ + b0 = BlockRV() + trace = Trace( + insts=[ + _make_get_block(name="B", output=b0), + _make_annotate(block=b0, annotation=annotation), + ], + decisions={}, + ) + json_obj = trace.as_json() + sch = tir.Schedule(elementwise, debug_mask="all") + Trace.apply_json_to_schedule(json_obj, sch) + tvm.ir.assert_structural_equal(elementwise_inlined, sch.mod["main"]) Review Comment: I think you may want to annotate the string, unanotate it and then compare with `elementwise` workload here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org