[GitHub] [tvm] Mousius commented on a diff in pull request #12509: [Target] Add target_device_type attribute to override default device_type

[GitBox]

Mousius commented on code in PR #12509:
URL: https://github.com/apache/tvm/pull/12509#discussion_r953949142


##########
include/tvm/target/target_kind.h:
##########
@@ -102,7 +102,7 @@ class TargetKindNode : public Object {
 
   void VisitAttrs(AttrVisitor* v) {
     v->Visit("name", &name);
-    v->Visit("device_type", &device_type);
+    v->Visit("default_device_type", &default_device_type);

Review Comment:
   I think it's a good idea to create the `PRERELEASE.md`, the one question I 
have is why under `tests`? It doesn't seem related to testing 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org