[GitHub] [tvm] shingjan commented on a diff in pull request #12581: [CUDA][CodeGen] Fix cuda codegen's fp16 inf literal

[GitBox]

shingjan commented on code in PR #12581:
URL: https://github.com/apache/tvm/pull/12581#discussion_r954289942


##########
src/target/source/codegen_cuda.cc:
##########
@@ -1197,8 +1197,10 @@ inline void PrintConst(const FloatImmNode* op, 
std::ostream& os, CodeGenCUDA* p)
       break;
     }
     case 16: {
-      os << "__float2half_rn";
-      os << '(' << std::scientific << op->value << 'f' << ')';
+      os << "__float2half_rn" << '(';

Review Comment:
   Would that be possible that we can add some test? We can probably re-use my 
repro [here](https://gist.github.com/shingjan/9ee06597a13f9be324828afb6c4560b8) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org