adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r955507870
########## tests/cpp-runtime/hexagon/ring_buffer_tests.cc: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + Review Comment: Added a unit test which overflows the HexagonUserDMA ring buffer for DMA descriptors. The test is named `overflow_ring_buffer`. Also added a return of `DMA_RETRY` from the HexagonUserDMA `Copy` function in case the ring buffer is full. This passes the onus to the user of the class to retry the `Copy`. The other way to handle it is for `Copy` to `Wait` until there is a free slot in the ring buffer to use. Not sure what is best at this moment. I am hoping the unit test provides the desired coverage. Would like to add integration tests in a separate test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
