alter-xp commented on PR #12534: URL: https://github.com/apache/tvm/pull/12534#issuecomment-1240259230
hi @PhilippvK > * For consistency, I refactored the CSI-NN2 insalll script to move the installation of the Linux toolchain to a separate script. As this has a few consequences, I would like to ask @alter-xp to review these changes: > > * CSI-NN is not anymore included in `Dockerfile.ci_cortexm` > * Both toolchains are now installed into `/opt/riscv` instead of `/opt/csi-nn2/` > * The `script/download_toolchain.sh` script is not used anymore. This also means that the installed version of the toolchain has to be kept in sync with the used version of CSI-NN2 by updating the TVM CI script. > * The used download URLs are hopefully to be replaced with more stable/similar ones once the toolchain will be open sourced These changes don't have much effect on me. Regarding the installation script here, I am also planning to separate it recently. I'm very glad you did it. > * After moving the gcc download out of the CSI-NN2 script, if might make sense to do the same with the QEMU installation. What do you think @alter-xp? I also intend to do this. Should we do it together in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
