junrushao commented on code in PR #12755:
URL: https://github.com/apache/tvm/pull/12755#discussion_r968746931
##########
tests/python/unittest/test_tvmscript_ir_builder_tir.py:
##########
@@ -28,18 +28,40 @@
def test_ir_builder_tir_primfunc():
with IRBuilder() as ib:
with T.prim_func():
+ T.arg("a", T.handle())
+ T.arg("b", T.var("int64"))
+ T.arg("c", T.buffer_decl((128, 128), "float32"))
+ d = T.arg("d", T.handle())
+ e = T.arg("e", T.buffer_decl((1024,), "int8"))
+ T.func_attr({"key": "value"})
+ T.func_ret(tvm.ir.PrimType("int64"))
+ buffer_d = T.match_buffer(d, (64, 64), "int64")
+ T.preflattened_buffer(e, (32, 32), "int8", data=e.data)
T.evaluate(0)
# the prim_func generated by IRBuilder
prim_func_actual = ib.get()
# the expected prim_func
+ c_handle, c_buffer = tir.Var("c_handle", "handle"), tir.decl_buffer(
Review Comment:
always add new tests instead of modifying existing simpler ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
