masahi commented on code in PR #12318: URL: https://github.com/apache/tvm/pull/12318#discussion_r969284123
########## gallery/how_to/work_with_pytorch/using_optimized_torch.py: ########## @@ -0,0 +1,176 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Compile PyTorch Models +====================== +**Author**: +`Yaoda Zhou <https://github.com/juda>`_, +`Masahiro Masuda <https://github.com/masahi>`_ + +This article is an introductory tutorial to optimize PyTorch models by using `tvm.contrib.torch.optimize_torch`. Review Comment: an introductory tutorial -> a tutorial ########## gallery/how_to/work_with_pytorch/using_as_torch.py: ########## @@ -0,0 +1,171 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Wrap Your TVMscript with PyTorch Module Review Comment: Is "Wrap ... with " the right phrase? I think "Wrap ... as PyTorch Module" is more correct. ########## gallery/how_to/work_with_pytorch/using_as_torch.py: ########## @@ -0,0 +1,171 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Wrap Your TVMscript with PyTorch Module +====================== +**Author**: +`Yaoda Zhou <https://github.com/juda>`_, +`Masahiro Masuda <https://github.com/masahi>`_ + +This article is an introductory tutorial on wrapping the TVMscript code with the PyTorch module. Review Comment: This article is a tutorial on wrapping TVMScript code as a PyTorch module. ########## gallery/how_to/work_with_pytorch/using_as_torch.py: ########## @@ -0,0 +1,171 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Wrap Your TVMscript with PyTorch Module +====================== +**Author**: +`Yaoda Zhou <https://github.com/juda>`_, +`Masahiro Masuda <https://github.com/masahi>`_ + +This article is an introductory tutorial on wrapping the TVMscript code with the PyTorch module. +By the decorator `as_torch`, users can wrap a TVMscript code into a PyTorch nn.Module naturally. Review Comment: "Using the decorator..." Drop "a" before TVMScript -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
