janetsc commented on PR #12957: URL: https://github.com/apache/tvm/pull/12957#issuecomment-1265527449
> > Our local simulator tests would time out after 1h, now they finish within 30 min. I used a subset of the fp16 conv tests, and without this change they would take about 45s per test, after the change they take about 15s per test. Have your simulator runs always taken this long, or did this recently start happening? I am wondering if I introduced this will resource management, and this points to needing to handle Free better after ReleaseResources has been called. (And that's the root culprit, not the logging, which should only be processed upon a failed check.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
