guberti commented on code in PR #12969:
URL: https://github.com/apache/tvm/pull/12969#discussion_r988333507


##########
tests/python/relay/strategy/arm_cpu/test_conv2d_nhwc.py:
##########
@@ -150,5 +147,38 @@ class TestConv2d_HWIO(BasicConv2dTests):
     schedule_name = tvm.testing.parameter("conv2d_nhwc_spatial_pack.arm_cpu")
 
 
+class TestConv2d_Tensordot(BasicConv2dTests):
+    data_shape, kernel_size, num_filter, strides, padding = 
tvm.testing.parameters(
+        # Disabled because these kernels are not an integral number of words

Review Comment:
   Currently, none of the 330 tests in `tests/python/relay/strategy/arm_cpu` 
check expected failure or fallback cases. In fact, they do not even check that 
the correct schedule (the one named in `schedule_name`) is used, as these are 
known limitations of `compile_and_run`.
   
   This wouldn't be too hard to add (and is totally worth doing!), but is 
probably OOS for this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to