junrushao commented on code in PR #12991:
URL: https://github.com/apache/tvm/pull/12991#discussion_r990591546


##########
python/tvm/meta_schedule/relay_integration.py:
##########
@@ -93,8 +93,15 @@ def _normalize_params(
         if isinstance(param, np.ndarray):
             param = nd.array(param)
         relay_params[name] = param
-    if executor is not None:
+
+    if executor is None:
+        executor = relay.backend.Executor("graph")
+
+    if mod.get_attr("executor") is None:
         mod = mod.with_attr("executor", executor)
+    else:
+        executor = mod.get_attr("executor")

Review Comment:
   quick question: why do we need the logic on line 97-98? i.e. is non-nullable 
`executor` useful in subsequent processing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to