[GitHub] [tvm] janetsc commented on a diff in pull request #13028: [Hexagon] [runtime] Manage RPC and runtime buffers separately

[GitBox]

janetsc commented on code in PR #13028:
URL: https://github.com/apache/tvm/pull/13028#discussion_r992787500


##########
src/runtime/hexagon/hexagon_device_api.h:
##########
@@ -190,16 +194,15 @@ class HexagonDeviceAPI final : public DeviceAPI {
            (DLDeviceType(dev.device_type) == kDLCPU);
   }
 
-  //! \brief Manages underlying HexagonBuffer allocations
+  //! \brief Manages RPC HexagonBuffer allocations
+  // rpc_hexbuffs is used only in Alloc/FreeRpcDataSpace
+  std::unique_ptr<HexagonBufferManager> rpc_hexbuffs;

Review Comment:
   It could be static, yes.  I'll make that change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org