Lunderberg commented on code in PR #12972:
URL: https://github.com/apache/tvm/pull/12972#discussion_r993589048


##########
include/tvm/arith/analyzer.h:
##########
@@ -297,6 +297,14 @@ class RewriteSimplifier {
      * if_then_else(i<j && j<k, i<k, false) => if_then_else(i<j && j<k, true, 
false)
      */
     kTransitivelyProveInequalities = (1 << 0),
+
+    /* When simplifying a boolean expression, convert to an AND of ORs
+     * (conjunctive normal form).
+     *
+     * Example:
+     *   (a || b) && c => (a && c) || (b && c)

Review Comment:
   Whoops, thank you.  This stuck around from an earlier draft where both 
conjunctive and disjunctive forms were represented in the class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to