guberti commented on code in PR #13051:
URL: https://github.com/apache/tvm/pull/13051#discussion_r999617874


##########
tests/python/relay/strategy/arm_cpu/test_group_conv2d.py:
##########
@@ -14,121 +14,44 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-import numpy as np
-import tvm
-import tvm.testing
-from tvm import relay
-from tvm.testing.aot import AOTTestModel, compile_and_run, generate_ref_data
-from tvm.micro.testing.aot_test_utils import AOT_CORSTONE300_RUNNER
+"""Tests for arm_cpu schedules for grouped conv2d."""
 
+from test_generalized_conv2d import GeneralizedConv2dTests
+from tvm.testing import main, parameter, parameters
 
-class BasicGroupConv2dTests:
-    @tvm.testing.requires_corstone300
-    def test_conv2d(
-        self,
-        data_shape,
-        data_layout,
-        kernel_size,
-        kernel_layout,
-        num_filter,
-        strides,
-        padding,
-        dilation,
-        groups,
-        dtype,
-        schedule_name,
-    ):
-        """Test a subgraph with a single conv2d operator."""
-        ishape = data_shape
 
-        assert groups > 1, f"groups should be more than 1 to create a group 
conv2d."
+class GroupConv2dTests(GeneralizedConv2dTests):
+    """Helper for constructing group Conv2ds. Sets the kernel layout to what 
x86 code supports."""

Review Comment:
   Fixed this in all three places it occurs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to