[GitHub] [tvm] janetsc commented on a diff in pull request #13138: [Hexagon] Support fetching and building Hexagon runtime with external runtime sources

Wed, 19 Oct 2022 13:43:04 -0700 


janetsc commented on code in PR #13138:
URL: https://github.com/apache/tvm/pull/13138#discussion_r999915616


##########
cmake/modules/Hexagon.cmake:
##########
@@ -182,6 +182,36 @@ if(BUILD_FOR_HEXAGON)
     "${TVMRT_SOURCE_DIR}/hexagon/ops/conv2d_fp16_hvx.cc"
     PROPERTIES COMPILE_FLAGS "-mhvx"
   )
+
+  # Include hexagon external library runtime sources
+  if(DEFINED USE_HEXAGON_EXTERNAL_LIBS)
+    if (EXISTS ${USE_HEXAGON_EXTERNAL_LIBS})

Review Comment:
   I'm a bit confused here.  Should line 188 check for 
HEXAGON_EXTERNAL_LIBS_SHA?  If we get here, USE_HEXAGON_EXTERNAL_LIBS exists, 
yes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to