mehrdadh commented on code in PR #13161: URL: https://github.com/apache/tvm/pull/13161#discussion_r1002212488
########## tests/python/contrib/test_hexagon/test_meta_schedule.py: ########## @@ -62,7 +64,7 @@ def main( # type: ignore # pylint: disable=no-self-argument @tvm.testing.requires_hexagon def test_builder_runner(hexagon_launcher): - if hexagon_launcher._serial_number == "simulator": + if android_serial_number()[0] == "simulator": Review Comment: Makes sense. The only issue here is that hexagon.session doesn't have access to serial number. We could pass serial number as input to the function and add is_simulator() function call -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
