[GitHub] [tvm] Alexey-Yazev commented on a diff in pull request #13369: [usmp] Hill Climb greedy layout size check relaxed

[GitBox]

Alexey-Yazev commented on code in PR #13369:
URL: https://github.com/apache/tvm/pull/13369#discussion_r1025005038


##########
tests/python/contrib/test_ethosu/test_networks.py:
##########
@@ -142,18 +141,8 @@ def 
test_networks_with_usmp_and_cascader_wo_striping(accel_type, model_url, work
 @pytest.mark.parametrize(
     "accel_type, model_url, workspace_size",
     [
-        # Checks the same test case multiple times to make sure its not flaky
-        ("ethos-u55-256", MOBILENET_V1_URL, 1010000),
-        ("ethos-u55-256", MOBILENET_V1_URL, 1010000),
-        ("ethos-u55-256", MOBILENET_V1_URL, 1010000),
-        ("ethos-u55-256", MOBILENET_V1_URL, 1010000),
-        ("ethos-u55-256", MOBILENET_V1_URL, 1010000),
-        # Checks the same test case multiple times to make sure its not flaky
-        ("ethos-u55-256", MOBILENET_V2_URL, 1400000),
-        ("ethos-u55-256", MOBILENET_V2_URL, 1400000),
-        ("ethos-u55-256", MOBILENET_V2_URL, 1400000),
-        ("ethos-u55-256", MOBILENET_V2_URL, 1400000),
-        ("ethos-u55-256", MOBILENET_V2_URL, 1400000),
+        ("ethos-u55-256", MOBILENET_V1_URL, 1005312),
+        ("ethos-u55-256", MOBILENET_V2_URL, 1162368),

Review Comment:
   As I see the test_networks.py passed, there are problems with the 
test_codegen.py. There are cases when buffer_info_arr (in 
HillClimbAllocator::PlanMemory) is empty, I suggest adding a size check for 
buffer_info_arr and return empty map in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org