Icemist commented on code in PR #13420:
URL: https://github.com/apache/tvm/pull/13420#discussion_r1026401405


##########
tests/python/unittest/test_runtime_rpc.py:
##########
@@ -448,10 +448,10 @@ def check_remote():
 
 
 @tvm.testing.requires_rpc
-def test_rpc_tracker_register():
+@pytest.mark.parametrize("device_key", ["test_device", "127.0.0.1:5555"])

Review Comment:
   > What is the problem to add one more key, e.g. 
hexagon-dev.192.168.0.143:5555:0.513619?
   
   It is not device key, it is internal representation inside implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to