chunit-quic commented on code in PR #13402:
URL: https://github.com/apache/tvm/pull/13402#discussion_r1030068605
##########
tests/python/frontend/test_common.py:
##########
@@ -27,6 +32,203 @@ def test_key_is_not_present():
assert not attrs.has_attr("b")
+def test_set_span():
Review Comment:
No problem!
##########
tests/python/relay/utils/tag_span.py:
##########
@@ -0,0 +1,106 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import tvm
+from tvm import relay, tir
+from tvm.relay.expr_functor import ExprVisitor
+
+
+def _set_span(expr, src):
Review Comment:
Thank you for let us know that we can leverage this function. :D
Yet about this _set_span, it is just a simple helper function and only used
in the tests. Would you hope to add the functions like CallWithFields or
TupleWithFields in C++ and expose them to python side in this patch? Or perhaps
this _set_span is enough for the test cases?
##########
tests/python/relay/utils/tag_span.py:
##########
@@ -0,0 +1,106 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import tvm
+from tvm import relay, tir
+from tvm.relay.expr_functor import ExprVisitor
+
+
+def _set_span(expr, src):
+ if isinstance(expr, relay.Call):
+ return relay.Call(expr.op, expr.args, expr.attrs, expr.type_args,
_create_span(src))
+ elif isinstance(expr, relay.Var):
+ return relay.var(expr.name_hint, expr.type_annotation, None, None,
_create_span(src))
+ elif isinstance(expr, relay.TupleGetItem):
+ return relay.TupleGetItem(expr.tuple_value, expr.index,
_create_span(src))
+ elif isinstance(expr, relay.Constant):
+ return relay.Constant(expr.data, _create_span(src))
+ elif isinstance(expr, relay.TupleWrapper):
+ return relay.TupleWrapper(_set_span(expr.tuple_value, src), expr.size)
+ elif isinstance(expr, relay.Tuple):
+ return relay.Tuple(expr.fields, _create_span(src))
+ elif isinstance(expr, tir.AttrStmt):
+ return tir.AttrStmt(expr.node, expr.attr_key, expr.value, expr.body,
_create_span(src))
+
+ assert False, f"unsupported type {type(expr)}"
+
+
+def _create_span(src):
+ if isinstance(src, list):
+ tmp_list = []
+ for s in src:
+ if isinstance(s, str):
+ tmp_list.append(_create_span(s))
+ elif isinstance(s, relay.Span):
+ tmp_list.append(s)
+ elif isinstance(s, relay.SequentialSpan):
+ tmp_list.extend(s.spans)
+ elif s is None:
+ tmp_list.append(s)
+ else:
+ assert False, f"unsupported type {type(s)}"
+ return relay.SequentialSpan(tmp_list)
+ return relay.Span(relay.SourceName(src), 0, 0, 0, 0)
+
+
+def _collect_spans(objref):
+ class Collector:
+ def __init__(self):
+ self._spans = []
+
+ def collect(self, objref):
+ if hasattr(objref, "span"):
+ self._spans.append(objref.span)
+
+ @property
+ def get_spans(self):
+ return self._spans
+
+ pov = None
+ if isinstance(objref, relay.Expr):
+ pov = relay.analysis.post_order_visit
+ elif isinstance(objref, (tir.Stmt, tir.expr.PrimExprWithOp)):
+ pov = tir.stmt_functor.post_order_visit
+ else:
+ assert False, f"unsupported type {type(objref)}"
+
+ c = Collector()
+ pov(objref, c.collect)
+ return c.get_spans
+
+
+def _verify_span(lhs, rhs):
+ lhs_spans, rhs_spans = _collect_spans(lhs), _collect_spans(rhs)
+
+ if len(lhs_spans) != len(rhs_spans):
+ return False
+
+ for i in range(len(lhs_spans)):
+ if not tvm.ir.structural_equal(lhs_spans[i], rhs_spans[i]):
+ return False
+ return True
Review Comment:
Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
