kparzysz-quic commented on code in PR #13591:
URL: https://github.com/apache/tvm/pull/13591#discussion_r1045925324
##########
src/target/llvm/llvm_instance.cc:
##########
@@ -297,9 +297,9 @@ llvm::TargetMachine*
LLVMTargetInfo::GetOrCreateTargetMachine(bool allow_missing
llvm_instance->createTargetMachine(triple_, cpu_,
GetTargetFeatureString(), target_options_,
reloc_model_, code_model_,
opt_level_);
target_machine_ = std::unique_ptr<llvm::TargetMachine>(tm);
- if (!allow_missing) {
Review Comment:
This is the only place where `target_machine_` is assigned a value, so this
check was actually sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
