Lunderberg commented on PR #13683:
URL: https://github.com/apache/tvm/pull/13683#issuecomment-1377408015

   > I have added this warning message especially to notify the user that the 
OpenCL wrapper will be used, and it might lead to a runtime error if the OpenCL 
library doesn't exist on a target device.
   
   Good point, as that is a runtime error that would occur on first usage, 
whereas all the other library dependencies would cause a failure when importing 
`libtvm_runtime.so`.
   
   > If warning message might embarrass, let's keep just status message?
   
   I like this idea, and have the message back in, but with `message(STATUS 
...)` instead of `message(WARNING ...)`.  I also adjusted the wording of the 
message to make it clear what the wrapper does (runtime search for library) and 
not just that a wrapper exists.  Could you check that the updated wording is 
accurate?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to