ashutosh-arm commented on code in PR #13736: URL: https://github.com/apache/tvm/pull/13736#discussion_r1066346962
########## docker/Dockerfile.ci_cortexm: ########## @@ -45,8 +45,8 @@ ENV PYTHONNOUSERSITE 1 # Disable .local directory from affecting CI. COPY install/ubuntu_install_python_package.sh /install/ubuntu_install_python_package.sh RUN bash /install/ubuntu_install_python_package.sh -COPY install/ubuntu1804_install_llvm.sh /install/ubuntu1804_install_llvm.sh -RUN bash /install/ubuntu1804_install_llvm.sh +COPY install/ubuntu2004_install_llvm.sh /install/ubuntu2004_install_llvm.sh +RUN bash /install/ubuntu2004_install_llvm.sh Review Comment: Yes, we will need to support `python3.7` until its EOL. Considering this, the next thing that pops up in my brain is when the `ci_cortexm` gets updated eventually corresponding to this change, will the default venv still remain at python3.7 or we would move cortex-m docker image to use `install/ubuntu2004_install_python.sh`? https://github.com/apache/tvm/blob/92da138bcb18c76604763785d3177de3f9f9b296/docker/Dockerfile.ci_cortexm#L38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
