ekalda commented on code in PR #13874:
URL: https://github.com/apache/tvm/pull/13874#discussion_r1092086314
##########
python/tvm/autotvm/tophub.py:
##########
@@ -110,6 +110,10 @@ def context(target, extra_files=None):
device = tgt.attrs.get("device", "")
if device != "":
possible_names.append(_alias(device))
+ # for cases when we do have explicitly defined -device in the target,
+ # we still might have information about it stored in keys container
+ # in other case we will load statistics for definitely irrelative stat
Review Comment:
Any chance this comment can be made clearer? :) I read it several times and
I don't get it.
`might have information`
What information?
`about it`
About what?
`keys container`
I guess that is Target.keys? Maybe make that more explicit
`in other case`
What case? When keys container is empty or when -device is not defined?
`irrelative stat`
What is irrelative stat?
Also, is it one or multiple sentences? Capital letters and punctuation would
be helpful :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
