elvin-n commented on code in PR #13874:
URL: https://github.com/apache/tvm/pull/13874#discussion_r1093093224


##########
python/tvm/autotvm/tophub.py:
##########
@@ -110,6 +110,10 @@ def context(target, extra_files=None):
         device = tgt.attrs.get("device", "")
         if device != "":
             possible_names.append(_alias(device))
+        # for cases when we do have explicitly defined -device in the target,
+        # we still might have information about it stored in keys container
+        # in other case we will load statistics for definitely irrelative stat

Review Comment:
   As for applying of the statistics, I am not even sure that taking statistics 
from another model of the same device is a good idea. Fortunately it more or 
less works for ARM CPU currently but if we take intel graphics, the previous 
models of Iris had different limitation of group worksize. Statistics which 
collected on newer graphics cannot be applied on previous one. I.e. we risk not 
to have bad performance but have just not working kernels.
   
   I.e. I agree that we need to do something with tophub and search algorithm, 
but do not have idea how we need to do this.
   
   And probably it is not so important assuming that Metaschedule should be the 
tuner #1. On the other hand MS is not a solution for default compilation 
without tuning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to