Mousius commented on PR #13926: URL: https://github.com/apache/tvm/pull/13926#issuecomment-1420894510
> Coming back to the branch establishment stage. It is indeed hard for community members who are not yet in the related code areas to be able to digest under the context of a single scaffolding commit. By design, a scaffolding commit connect to a broader context that will appear in the future(such as how IR node is being used, printed and parsed exactly) when connecting things together and are subject to future iterations(and rewrites in needed cases such as rebasing to main). If we cannot review changes in isolation, that indicates the changes are not well broken down and delivered for review. There are foundational issues with this PR, such as being over 8,000 lines, a vague commit message and being merged in 5 hours - all of which work to exclude reviewers who may not see the PR or feel their reviews have no meaning once the PR gets merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
