adstraw commented on code in PR #13721:
URL: https://github.com/apache/tvm/pull/13721#discussion_r1113056594


##########
include/tvm/meta_schedule/schedule_rule.h:
##########
@@ -210,6 +210,31 @@ class ScheduleRule : public runtime::ObjectRef {
       Optional<Array<Integer>> vector_load_lens, Optional<Map<String, 
ObjectRef>> reuse_read,
       Optional<Map<String, ObjectRef>> reuse_write, bool 
use_software_pipeline);
 
+  /*!
+   * \brief Extension of MultiLevelTiling for auto-tensorization with multiple 
groups of candidate
+   * tensor core intrinsics
+   * \param intrin_groups A list of groups of tensor core intrinsics. The map 
should contain key
+   * "compute" which represents the tensor intrin for computation. The value 
of the map should be
+   * names of tensor intrinsics, must be registered via
+   * TensorIntrin.register(...) beforehand
+   * \param structure The tiling structure. Recommended:
+   * - 'SRSRS' on Hexagon

Review Comment:
   It just took me a minute to make the connection between the Hexagon layout 
(NCHWc) and the tiling structure (SRSRS) which led me to suggest a comment to 
clarify.  The key thing for my understanding when I originally reviewed the 
code was to connect R=Reduction to the C=Channel axes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to