MasterJH5574 commented on code in PR #14111:
URL: https://github.com/apache/tvm/pull/14111#discussion_r1117640490
##########
src/script/printer/tir/expr.cc:
##########
@@ -222,23 +222,9 @@ TVM_STATIC_IR_FUNCTOR(IRDocsifier, vtable)
.set_dispatch<tir::Call>("", [](tir::Call call, ObjectPath call_p,
IRDocsifier d) -> Doc {
static const OpAttrMap<tir::TScriptPrinterName>& op_names =
Op::GetAttrMap<tir::TScriptPrinterName>("TScriptPrinterName");
- static const std::unordered_set<const Object*> dtype_first_arg = {
- tir::builtin::reinterpret().get(),
- tir::builtin::call_extern().get(),
- tir::builtin::call_llvm_intrin().get(), //
- tir::builtin::call_llvm_pure_intrin().get(), //
- tir::builtin::call_pure_extern().get(), //
- tir::builtin::ptx_mma().get(),
- tir::builtin::ptx_mma_sp().get(),
- tir::builtin::ptx_ldmatrix().get(),
- tir::builtin::ptx_cp_async().get(),
- tir::builtin::mma_store().get(),
- tir::builtin::mma_fill().get(),
- tir::builtin::vectorlow().get(),
- tir::builtin::vectorhigh().get(),
- tir::builtin::vectorcombine().get(),
- Op::Get("tir.type_annotation").get(),
- };
+ static const OpAttrMap<tir::TScriptDtypePrintLocation> dtype_locations =
+
Op::GetAttrMap<tir::TScriptDtypePrintLocation>("TScriptDtypePrintLocation");
+ tir::ScriptDtypePrintLocation dtype_print_location =
tir::ScriptDtypePrintLocation::kNone;
static const std::unordered_set<const Object*> dtype_last_arg = {
Review Comment:
Thanks for the improvement! I suppose the `dtype_last_arg` can be smoothly
removed right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
