lhutton1 commented on code in PR #14175:
URL: https://github.com/apache/tvm/pull/14175#discussion_r1123810642
##########
tests/python/driver/tvmc/test_command_line.py:
##########
@@ -210,3 +210,45 @@ def test_tvmc_compile_input_model(mock_compile_model,
tmpdir_factory, model):
_main(run_arg)
mock_compile_model.assert_called_once()
+
+
+# TODO(ekalda): This test just makes sure that we log - unfortunately pytest
seems to intercept
Review Comment:
Yeah I think pytest overwrites the logging handlers :( I think you could
somewhat check this with mocking, at least check that
`logging.basicConfig(stream=sys.stdout)` was called with the correct arguments
- there's a similar example here
https://github.com/apache/tvm/blob/23ade0c14b29c2c2710f6580035878f130eea52b/tests/python/driver/tvmc/test_transform.py#L50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
