PhilippvK opened a new pull request, #14272:
URL: https://github.com/apache/tvm/pull/14272

   this aims to make the `--desired-layout` argument more powerful based on the 
previously merged changes from #14010 (@srkreddy1238) by introducing two new 
features:
   
   1. Allow passing multiple arguments to `--desired-layout` instead of only 
one, to specify one layout per transformed operator specified in 
`--desired-layout-ops`. (Number of arguments has to bei either 1 or match the 
number of transformed operators)
   2. Optionally, you can now specify a non-default kernel layout as follows: 
`NHWC:HWIO`
   
   Example Usage: `tvmc compile … --desired-layout nn.max_pool2d qnn.conv2d 
--desired-layout-ops NCHW NHWC:HWIO`
   
   I also added unit tests for the new use-cases.
   
   ### Known Limitations:
   * It would make sense to specify individual kernel layouts for regular 
convolutions and depthwise ones. However since both are usually implemented as 
generalized `nn.conv2d`, we can not transform them individually. Are there any 
good workarounds for this?
   * The arguments of `--desired-layouts` have previously been checked for 
validity during cmdline parsing (e.g. only NCHW and NHWC are allowed) which is 
not possible anymore. Should I add a regular expression for that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to