quic-sanirudh commented on PR #14294:
URL: https://github.com/apache/tvm/pull/14294#issuecomment-1467780883

   cc @Lunderberg @kparzysz-quic
   
   There is a comment in 
[`layout_transformation.cc`](https://github.com/apache/tvm/blob/ccc0b9162f2e983a8810e99c903c7141dbec81b6/src/tir/schedule/primitive/layout_transformation.cc#L48-L50)
 which suggests that `tir.assume` might be removed during lowering, but it 
seems that the 
[`tir.remove_assume`](https://github.com/apache/tvm/blob/ccc0b9162f2e983a8810e99c903c7141dbec81b6/src/tir/transforms/remove_assume.cc)
 pass has not yet been added to the default list of passes and so I ran into an 
error while lowering with assume.
   
   Instead of adding this pass as a default one, I've added support to generate 
`llvm.assume` since this info might be useful for LLVM optimizations as well, 
and users can still manually add the `tir.remove_assume` pass before lowering 
to remove it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to