lhutton1 commented on PR #14273: URL: https://github.com/apache/tvm/pull/14273#issuecomment-1470002372
Thanks for looking into fixing this @PhilippvK, overall I think it would be very useful to expose additional passes to the disabled pass option. Here are my thoughts: Allowing relay.ABC makes sense to me, but I think there could be a deeper design problem here. I would argue that we can remove the prefix all together and use the pass names exactly as they are defined in the code. Personally, as a developer wanting to disable a particular pass, I'd find the pass name in the code, then expect to use this same name with the `--disable-pass` option. Also, while I don't believe it's the case currently, we could have a scenario where a replaced pass name results in a collision e.g. `tir.my.namespace.ABC` and `tir.my.namespace2.ABC` -> `tir.ABC`. Passes with odd names such as `*._transform.*` which the prefix mechanism seems to work around can always be renamed in the codebase so they as more sensible. I think this helps solve some of the discussion questions you listed, happy to hear other thoughts and opinions on this :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
