tqchen commented on code in PR #13088: URL: https://github.com/apache/tvm/pull/13088#discussion_r1143768390
########## python/tvm/script/_parser/core/dispatch.py: ########## @@ -0,0 +1,156 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Parser dispatching infrastructure""" + +from typing import TYPE_CHECKING, Any, Callable, Dict, Optional, Tuple, Type + +from .doc import AST + +if TYPE_CHECKING: + from .parser import Parser + + +ParseMethod = Callable[["Parser", AST], None] +ParseVTable: Dict[Tuple[str, str], ParseMethod] = {} + +OpMethod = Callable[..., Any] +OpVTable: Dict[Tuple[Type, AST, int], OpMethod] = {} + + +def register(token: str, type_name: str): + """Register a method for a dispatch token and type name. + + Parameters + ---------- + token : str + The token for IR, e.g., T for TIR and R for Relax. Review Comment: In this case the particular code owners who are developing the modules of the module is not confused. This is an API used by TVMScript internally, if any one of the TVMScript maintainer feels it is out of place. I think they should be able to come and fix it. But my take is that they are not, as such I would hope to appreciate the volunteering effort of the module maintainers and let them make the call. Thanks for the suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
