masahi commented on code in PR #14548:
URL: https://github.com/apache/tvm/pull/14548#discussion_r1163366220
##########
include/tvm/topi/transform.h:
##########
@@ -2035,6 +2034,73 @@ inline Tensor adv_index(const Tensor& data, const
Array<Tensor>& indices,
name, tag);
}
+namespace relax {
+// relax dynamic slice
+inline te::Tensor dynamic_strided_slice(const te::Tensor& x, const te::Tensor&
begin,
+ const te::Tensor& end, const
te::Tensor& strides,
+ Array<PrimExpr> output_shape,
+ std::string name =
"T_strided_slice_dynamic",
+ std::string tag = kInjective) {
Review Comment:
This, again, sounds odd to me to talk about legalizer vs topi distinction.
Since `dynamic_strided_slice` and the shape func is only meant to be used by
the legalizer, why not just define them here? There is no need to be concerned
about "TOPI side".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
