FranklandJack commented on code in PR #14519:
URL: https://github.com/apache/tvm/pull/14519#discussion_r1171436553
##########
python/tvm/topi/arm_cpu/depthwise_conv2d.py:
##########
@@ -394,7 +394,8 @@ def schedule_conv_out(out):
ci_outer, ci_inner = s[out].split(ci, 4)
s[out].vectorize(ci_inner)
s[out].unroll(ci_outer)
-
+ else:
+ s[out].vectorize(ci)
Review Comment:
Cool, thanks for the suggestion, I've added a filter on the split.
Yeah I think you are almost correct, for neon where vectors are `128` bits
and `sizeof(float) = 32`, then there will be `128 / 32 = 4` elements processed
in each vector operation. I think the backend will split the 8 element llvm
vectors into two 4 element vectors during legalization, so this isn't a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
