echuraev commented on code in PR #14707:
URL: https://github.com/apache/tvm/pull/14707#discussion_r1176026891
##########
tests/python/frontend/keras/test_forward.py:
##########
@@ -209,6 +211,15 @@ def test_forward_activations(self, keras_mod):
keras_model = keras_mod.models.Model(data, x)
verify_keras_frontend(keras_model)
verify_keras_frontend(keras_model, need_transpose=False,
layout="NHWC")
+ # test invalid attribute alpha=None for LeakyReLU
+ if package_version.parse(keras_mod.__version__.split("-tf")[0]) <=
package_version.parse(
+ "2.3.1"
+ ):
Review Comment:
I see your point, thank you. I'm not sure if it is the best option to have
such condition in the test. Another variant, we can catch exception from TF if
keras version is higher as 2.3.1 and if no exception was generated by TF then
we will try to verify our frontend.
Current option is also LGTM. Let's discuss with other folks what is the best
option in the test. @AndrewZhaoLuo, @leandron what do you think, should we
check Keras version in test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
