masahi commented on code in PR #14792:
URL: https://github.com/apache/tvm/pull/14792#discussion_r1187288604
##########
src/runtime/opencl/opencl_module.cc:
##########
@@ -108,7 +109,27 @@ class OpenCLWrappedFunc {
LaunchParamConfig launch_param_config_;
};
-OpenCLModuleNode::~OpenCLModuleNode() {
+class OpenCLSPIRVModuleNode : public OpenCLModuleNodeBase {
Review Comment:
Ok, made the following changes:
* Add `runtime/spirv` dir and put `SPIRVShader` there
* Add `runtime/opencl/opencl_module_spirv.cc` and put
`OpenCLSPIRVModuleNode` and related code there.
Overall I also like this organization. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
