kparzysz-quic commented on code in PR #15057: URL: https://github.com/apache/tvm/pull/15057#discussion_r1227259339
########## tests/python/contrib/test_hexagon/test_qnn_op_integration.py: ########## @@ -0,0 +1,455 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# pylint: disable=invalid-name,missing-function-docstring,redefined-outer-name + +""" Test Relay integrated qnn ops +There are two types of tests for qnn ops in this file. One to verify the +correctness of the relay integration and the other one to verify +the fake quantization to integer implemented for picking up the qnn op. +The former is only executed when qnn canonicalization is disabled. +The latter is executed both with and without canonicalization. +""" +# TODO: We might want to distribute these test cases into other test cases such as +# test_wo_qnn_canonicalization and test_pass_fake_quantization_to_integer in the future. Review Comment: There is already a test for avgpool2d in `tests/python/relay/test_pass_fake_quantization_to_integer.py`. The tests from this file (`test_qnn_op_integration.py`) execute on Hexagon and require all the fixtures from `tests/python/contrib/test_hexagon`. Regarding migration of `test_wo_qnn_canonicalization` to this file: I've started working on this, but this file contains a number of fixtures that assume that there is only one tensor input. Seems like migrating tests from this file over to "wo_canonicalization" would be easier (both to write and to read later on). What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
