srkreddy1238 commented on PR #15058: URL: https://github.com/apache/tvm/pull/15058#issuecomment-1590823234
Thanks @echuraev and @tqchen for a quick review. I see ```MemoryManager``` can meet the requirements of the pool concept we have here. I will improve the PR by - Initializing the MemoryManager (PooledAllocator) from graph runtime (StorageSetup). - ```NDArray->Empty``` => ```PooledAllocator->Empty``` (Assuming Pooled Allocator works for all runtimes or I cam limit this for texture scoped graphs). - ```NDArray->CreateView``` => ```DeviceAPI->AllocDataSpaceView``` : This will take care of various views over NDArray Another situation I came across multiple is about ```runtime::GetDataSize(container->dl_tensor)``` Can we move this to DeviceAPI ? In case of texture there is device specific attributes (image row pitch) that defines the underlaying memory size and accessing these attributes outside doesn't look to be a great idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
