zxybazh commented on code in PR #15466:
URL: https://github.com/apache/tvm/pull/15466#discussion_r1283487135


##########
python/tvm/dlight/benchmark/utils.py:
##########
@@ -101,7 +106,11 @@ def populuate_input_shape(
     return results
 
 
-def default_dym_var_sample_func(dym_var_dict: Dict[str, str]) -> Dict[str, 
int]:
+def default_dym_var_sample_func(
+    dym_var_dict: Dict[str, str],
+    sample_idx: int,  # pylint: disable=unused-argument

Review Comment:
   Yes, this default sample function doesn't use `sample_idx` but it could be 
very useful for other use cases. For example, we may want to use 
`n=2^sample_idx` for the samplings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to