This is an automated email from the ASF dual-hosted git repository.
zhifgli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new aa18be0 [Minor] Make config keys final (#70)
aa18be0 is described below
commit aa18be05ab7c00cd04b98134c11fdbe898893e95
Author: Kaijie Chen <[email protected]>
AuthorDate: Tue Jul 26 11:48:17 2022 +0800
[Minor] Make config keys final (#70)
### What changes were proposed in this pull request?
Make config keys and default values in `RssClientConfig` final.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI.
---
.../java/org/apache/uniffle/client/util/RssClientConfig.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/client/src/main/java/org/apache/uniffle/client/util/RssClientConfig.java
b/client/src/main/java/org/apache/uniffle/client/util/RssClientConfig.java
index 22f662b..43204e2 100644
--- a/client/src/main/java/org/apache/uniffle/client/util/RssClientConfig.java
+++ b/client/src/main/java/org/apache/uniffle/client/util/RssClientConfig.java
@@ -54,15 +54,15 @@ public class RssClientConfig {
public static final int RSS_INDEX_READ_LIMIT_DEFAULT_VALUE = 500;
public static final String RSS_CLIENT_SEND_THREAD_NUM =
"rss.client.send.thread.num";
public static final int RSS_CLIENT_DEFAULT_SEND_NUM = 5;
- public static String RSS_CLIENT_READ_BUFFER_SIZE =
"rss.client.read.buffer.size";
+ public static final String RSS_CLIENT_READ_BUFFER_SIZE =
"rss.client.read.buffer.size";
// When the size of read buffer reaches the half of JVM region (i.e., 32m),
// it will incur humongous allocation, so we set it to 14m.
- public static String RSS_CLIENT_READ_BUFFER_SIZE_DEFAULT_VALUE = "14m";
+ public static final String RSS_CLIENT_READ_BUFFER_SIZE_DEFAULT_VALUE = "14m";
// The tags specified by rss client to determine server assignment.
- public static String RSS_CLIENT_ASSIGNMENT_TAGS =
"rss.client.assignment.tags";
+ public static final String RSS_CLIENT_ASSIGNMENT_TAGS =
"rss.client.assignment.tags";
- public static String RSS_ACCESS_TIMEOUT_MS = "rss.access.timeout.ms";
- public static int RSS_ACCESS_TIMEOUT_MS_DEFAULT_VALUE = 10000;
+ public static final String RSS_ACCESS_TIMEOUT_MS = "rss.access.timeout.ms";
+ public static final int RSS_ACCESS_TIMEOUT_MS_DEFAULT_VALUE = 10000;
public static final String RSS_DYNAMIC_CLIENT_CONF_ENABLED =
"rss.dynamicClientConf.enabled";
public static final boolean RSS_DYNAMIC_CLIENT_CONF_ENABLED_DEFAULT_VALUE =
true;
}